Ensure $request->hasSession() is always checked before calling getSession() #32703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why you're proposing this? |
|
@nicolas-grekas |
|
We do not change code that works. We did such refactoring in the past and that introduced some bugs. So, we either refactor to fix a bug or we keep the current code. |
nicolas-grekas
approved these changes
Jul 27, 2019
xabbuh
requested changes
Jul 27, 2019
|
@nicolas-grekas thank you. |
chalasr
approved these changes
Jul 27, 2019
xabbuh
previously requested changes
Jul 27, 2019
|
@xabbuh fixed, thanks |
xabbuh
approved these changes
Jul 28, 2019
|
Thank you @Arman-Hosseini. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 30, 2019
…ling getSession() (Arman-Hosseini) This PR was merged into the 4.4 branch. Discussion ---------- Ensure $request->hasSession() is always checked before calling getSession() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7b2c326 Ensure $request->hasSession() is always checked before calling getSession()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.