Make sure trace_level is always defined #32802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2019
fabpot
approved these changes
Jul 30, 2019
|
Thank you @dbu. |
fabpot
added a commit
that referenced
this pull request
Jul 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Make sure trace_level is always defined | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32801 | License | MIT | Doc PR | - Fix bug introduced in 9a2fcc9 When running the HttpCache kernel with debug option false and no explicit trace_level, the default does not get initialized. The kernel still unconditionally calls addTraces. @andrerom found this while looking at tests output of FOSHttpCache: https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/tests/Unit/SymfonyCache/EventDispatchingHttpCacheTest.php https://travis-ci.org/FriendsOfSymfony/FOSHttpCache/jobs/565046971 Commits ------- b80e9b8 Make sure trace_level is always defined
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in 9a2fcc9
When running the HttpCache kernel with debug option false and no explicit trace_level, the default does not get initialized. The kernel still unconditionally calls addTraces.
@andrerom found this while looking at tests output of FOSHttpCache: https://github.com/FriendsOfSymfony/FOSHttpCache/blob/master/tests/Unit/SymfonyCache/EventDispatchingHttpCacheTest.php
https://travis-ci.org/FriendsOfSymfony/FOSHttpCache/jobs/565046971