Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Lock] let BlockingStoreInterface extend PersistingStoreInterface #32803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 29, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #32555 (comment)
License MIT
Doc PR

@nicolas-grekas
Copy link
Member

/cc @jderusse

Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove PersistingStoreInterface from stores who implements both interfaces?

class RetryTillSaveStore implements PersistingStoreInterface, BlockingStoreInterface, StoreInterface, LoggerAwareInterface

@xabbuh
Copy link
Member Author

xabbuh commented Jul 30, 2019

@jderusse fixed

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit eaad40e into symfony:4.4 Jul 30, 2019
nicolas-grekas added a commit that referenced this pull request Jul 30, 2019
…terface (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] let BlockingStoreInterface extend PersistingStoreInterface

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32555 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

eaad40e let BlockingStoreInterface extend PersistingStoreInterface
@xabbuh xabbuh deleted the pr-32555 branch July 30, 2019 17:51
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants