Create mailBody with only attachments part present #32814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srsbiz
commented
Jul 30, 2019
| Q | A |
|---|---|
| Branch? | 4.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32811 |
| License | MIT |
javiereguiluz
approved these changes
Jul 31, 2019
|
It looks like an edge case to me. I think that you should be explicit about the "empty" body by using |
This creates first - empty part of mime message which does not work for me - one application I'm maintaining exchanges data with other service via email - and this have to be only one attachment with specific title. Currently app relies on swiftmailer, where adding attachment creates only one part - as expected. |
fabpot
requested changes
Aug 3, 2019
fabpot
approved these changes
Aug 4, 2019
0752ee5 to
b500f92
Compare
|
Thank you @srsbiz. |
fabpot
added a commit
that referenced
this pull request
Aug 4, 2019
This PR was squashed before being merged into the 4.3 branch (closes #32814). Discussion ---------- Create mailBody with only attachments part present | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32811 | License | MIT Commits ------- b500f92 Create mailBody with only attachments part present
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.