[Messenger] Removed named parameters and replaced with ? placeholders for sqlsrv compatibility
#32836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 4, 2019
seriquynh
approved these changes
Aug 5, 2019
fabpot
approved these changes
Aug 5, 2019
…rs for sqlsrv compatibility
|
Thank you @dlegatt. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2019
… placeholders for sqlsrv compatibility (David Legatt) This PR was squashed before being merged into the 4.3 branch (closes #32836). Discussion ---------- [Messenger] Removed named parameters and replaced with `?` placeholders for sqlsrv compatibility | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32585 | License | MIT | Doc PR | I edited the Doctrine Transport Connection class to use `?` placeholders in the query builder instead of named repositories as this resulted in a compatibility issue with SQL Server. Commits ------- fc0e4ba [Messenger] Removed named parameters and replaced with `?` placeholders for sqlsrv compatibility
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited the Doctrine Transport Connection class to use
?placeholders in the query builder instead of named repositories as this resulted in a compatibility issue with SQL Server.