Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add yceruto as code owner of the ErrorRenderer component #32964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2019
Merged

add yceruto as code owner of the ErrorRenderer component #32964

merged 1 commit into from
Aug 6, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Aug 5, 2019 •
edited
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

@yceruto yceruto force-pushed the error_renderer_code_owner branch 2 times, most recently from 286c2f9 to 1a57c09 Compare August 5, 2019 20:28
@yceruto yceruto changed the base branch from 3.4 to 4.4 August 5, 2019 20:32
@yceruto yceruto force-pushed the error_renderer_code_owner branch from 1a57c09 to eea4aad Compare August 5, 2019 20:32
@nicolas-grekas nicolas-grekas added this to the next milestone Aug 6, 2019
@yceruto yceruto force-pushed the error_renderer_code_owner branch from 0317427 to 2e8e15c Compare August 6, 2019 12:12
@nicolas-grekas nicolas-grekas force-pushed the error_renderer_code_owner branch from 2e8e15c to df6e73d Compare August 6, 2019 12:17
@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit df6e73d into symfony:4.4 Aug 6, 2019
nicolas-grekas added a commit that referenced this pull request Aug 6, 2019
@nicolas-grekas
minor #32964 add yceruto as code owner of the ErrorRenderer component…
fc8872f 
… (yceruto)

This PR was squashed before being merged into the 4.4 branch (closes #32964).

Discussion
----------

add yceruto as code owner of the ErrorRenderer component

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

df6e73d add yceruto as code owner of the ErrorRenderer component
@yceruto yceruto deleted the error_renderer_code_owner branch August 6, 2019 12:22
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@yceruto @nicolas-grekas @fabpot @chalasr @carsonbot