[HttpClient] Declare $active first to prevent weird issue
#32989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$active first to prevent weird issue$active first to prevent weird issue
nicolas-grekas
approved these changes
Aug 6, 2019
|
Hum, it seems that this PR actually brokes tests...
|
|
Would using |
|
I don't have the time for now, I will check it out this evening. |
|
Huh, so I don't understand why. It's a variable declared in a reference so it should be ok... Maybe because of a weird PHP configuration, it fails? |
nicolas-grekas
approved these changes
Aug 7, 2019
There was a problem hiding this comment.
(issue in tests was unrelated to this PR and has been fixed in #33005)
|
Thank you @Kocal. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 7, 2019
…e (Kocal) This PR was squashed before being merged into the 4.3 branch (closes #32989). Discussion ---------- [HttpClient] Declare `$active` first to prevent weird issue | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | - <!-- please add some, will be required by reviewers --> | Fixed tickets | #32833 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | no In some undefined cases we can have the following error while using the WebTestCase/CurlHttpClient in PHPUnit:  This is really weird because `$active` is a reference and so it does not need to be declared before, but doing that fixes the issue. (#32833 (comment)) I can't add tests because we were not able to reproduce the issue... Commits ------- ba030f0 [HttpClient] Declare `$active` first to prevent weird issue
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some undefined cases we can have the following error while using the WebTestCase/CurlHttpClient in PHPUnit:
This is really weird because
$activeis a reference and so it does not need to be declared before, but doing that fixes the issue. (#32833 (comment))I can't add tests because we were not able to reproduce the issue...