Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[EventDispatcher] wrong Request class #33093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2019
Merged

[EventDispatcher] wrong Request class #33093

merged 1 commit into from
Aug 9, 2019

Conversation

maxhelias
Copy link
Contributor

@maxhelias maxhelias commented Aug 9, 2019 •
edited
Loading

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@yceruto yceruto modified the milestones: 5.0, 4.3 Aug 9, 2019
@yceruto
Copy link
Member

yceruto commented Aug 9, 2019

Should be fixed since 4.3

@maxhelias maxhelias changed the base branch from master to 4.3 August 9, 2019 13:58
@maxhelias maxhelias changed the title [5.0][EventDispatcher] wrong Request class [EventDispatcher] wrong Request class Aug 9, 2019
@maxhelias
Copy link
Contributor Author

@yceruto Indeed, I changed the target branch, thanks 😃

@yceruto
Copy link
Member

yceruto commented Aug 9, 2019

Good catch, thanks @maxhelias.

@yceruto yceruto merged commit 97d6184 into symfony:4.3 Aug 9, 2019
yceruto added a commit that referenced this pull request Aug 9, 2019
@yceruto
bug #33093 [EventDispatcher] wrong Request class (maxhelias)
a944f29 
This PR was merged into the 4.3 branch.

Discussion
----------

[EventDispatcher] wrong Request class

| Q             | A
| ------------- | ---
| Branch?       | 4.3 <!-- see below -->
| Bug fix?      | yes
| New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

97d6184 [EventDispatcher] wrong Request class
@maxhelias maxhelias deleted the type branch August 9, 2019 14:19
@fabpot fabpot mentioned this pull request Aug 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto yceruto approved these changes

@seriquynh seriquynh seriquynh approved these changes

Assignees
No one assigned
Labels
Bug EventDispatcher Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@maxhelias @yceruto @xabbuh @seriquynh @carsonbot