[Mailer] Don't duplicate addresses in Sendgrid Transport #33210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db3b66c to
665cee8
Compare
665cee8 to
2706a97
Compare
fabpot
reviewed
Aug 16, 2019
src/Symfony/Component/Mailer/Bridge/Sendgrid/Http/Api/SendgridTransport.php
Show resolved
Hide resolved
fabpot
approved these changes
Aug 17, 2019
|
Thank you @pierredup. |
fabpot
added a commit
that referenced
this pull request
Aug 17, 2019
…pierredup) This PR was merged into the 4.3 branch. Discussion ---------- [Mailer] Don't duplicate addresses in Sendgrid Transport | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33135 | License | MIT | Doc PR | N/A Sendgrid requires the `to`, `cc` and `bcc` fields to be unique Commits ------- 2706a97 Don't duplicate addresses in Sendgrid Transport
Merged
|
Is it possible to get this into |
|
This PR was merged into the |
|
You're right, it was merged and subsequently reverted on #37872. I'll look into this more and open a new issue if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendgrid requires the
to,ccandbccfields to be unique