Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle][TwigBundle] conflict with HttpKernel 5 #33390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

[FrameworkBundle][TwigBundle] conflict with HttpKernel 5 #33390

merged 1 commit into from
Aug 30, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 30, 2019

Q A
Branch? 4.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets replaces #33356
License MIT
Doc PR

@xabbuh xabbuh added this to the next milestone Aug 30, 2019
@xabbuh xabbuh mentioned this pull request Aug 30, 2019
Closed
@xabbuh xabbuh force-pushed the http-kernel-conflict branch from d79f3c5 to 7d94b7c Compare August 30, 2019 11:37
@xabbuh xabbuh changed the title [FrameworkBundle] conflict with HttpKernel 5 [FrameworkBundle][TwigBundle] conflict with HttpKernel 5 Aug 30, 2019
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request Aug 30, 2019
@nicolas-grekas
minor #33390 [FrameworkBundle][TwigBundle] conflict with HttpKernel 5…
15bbfc3 
… (xabbuh)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][TwigBundle] conflict with HttpKernel 5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | replaces #33356
| License       | MIT
| Doc PR        |

Commits
-------

7d94b7c conflict with HttpKernel 5
@nicolas-grekas nicolas-grekas merged commit 7d94b7c into symfony:4.4 Aug 30, 2019
@xabbuh xabbuh deleted the http-kernel-conflict branch August 30, 2019 12:41
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review TwigBundle
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot