[Mailer] Added messenger to dev dependencies #33480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 5, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Added messenger to dev dependencies | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A PR #33454 introduced a new test case that mocks the `MessageBusInterface` from the messenger component. This makes the tests suite fail on travis because PHPUnit refuses to create a mock for an interface that does not exist. ``` There was 1 failure: 1) Symfony\Component\Mailer\Tests\MailerTest::testSendingRawMessages Failed asserting that exception of type "PHPUnit\Framework\MockObject\RuntimeException" matches expected exception "Symfony\Component\Mailer\Exception\LogicException". Message was: "Cannot stub or mock class or interface "Symfony\Component\Messenger\MessageBusInterface" which does not exist" at /home/travis/build/symfony/symfony/src/Symfony/Component/Mailer/Tests/MailerTest.php:28 ``` This PR fixes the test by adding the Messenger component to Mailer's dev dependencies. Commits ------- 248f082 [Mailer] Added messenger to dev dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #33454 introduced a new test case that mocks the
MessageBusInterfacefrom the messenger component. This makes the tests suite fail on travis because PHPUnit refuses to create a mock for an interface that does not exist.This PR fixes the test by adding the Messenger component to Mailer's dev dependencies.