Fix lint commands frozen on empty stdin #33523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8daae93 to
06702ed
Compare
|
The fact it works is relying on a race condition. Don't be fooled. For 4.4 only, master shouldn't rely on ftell() |
|
Sure, but it's a behavior change which might give false positives in a CI. Take e.g: cat unexisting | bin/console lint:yamlOn 4.3 the output is an error message and exit code is 1. On 4.4-dev it succeeds with code 0. |
5f1ac9d to
6472304
Compare
yceruto
approved these changes
Sep 12, 2019
nicolas-grekas
approved these changes
Sep 18, 2019
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 18, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Fix lint commands frozen on empty stdin | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Running e.g. `lint:yaml -` with no piped content makes the command hangs currently, this makes it fail instead. Also fixes the command help which we forgot to update Commits ------- b60e0c1 Fix lint commands frozen on empty stdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running e.g.
lint:yaml -with no piped content makes the command hangs currently, this makes it fail instead. Also fixes the command help which we forgot to update