Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] added Ability to define a priority method for tagged service #33628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

[DependencyInjection] added Ability to define a priority method for tagged service #33628

merged 1 commit into from
Oct 2, 2019

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Sep 18, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #32976
License MIT
Doc PR

@lyrixx lyrixx mentioned this pull request Sep 18, 2019
Closed
@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch from 3f70b43 to b82dcb5 Compare September 18, 2019 14:39
@nicolas-grekas nicolas-grekas added this to the next milestone Sep 18, 2019
@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch from b82dcb5 to bf6d037 Compare September 18, 2019 15:05
@lyrixx
Copy link
Member Author

lyrixx commented Sep 18, 2019

I added much more tests :D

@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch 2 times, most recently from d102fa3 to 20b8761 Compare September 23, 2019 15:22
@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch 2 times, most recently from db5f9fb to 5dac5c0 Compare September 27, 2019 12:32
@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch from 5dac5c0 to 792a7ea Compare September 27, 2019 13:03
nicolas-grekas
nicolas-grekas approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(failure unrelated)

@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch from 792a7ea to 50ead19 Compare September 27, 2019 13:06
@lyrixx
Copy link
Member Author

lyrixx commented Sep 27, 2019 •
edited
Loading

No more failures 💚

@lyrixx
Copy link
Member Author

lyrixx commented Oct 1, 2019

@nicolas-grekas Let's merge it?

yceruto
yceruto approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a needed feature, thank you!

( I left a nitpicking comment :) )

@lyrixx lyrixx force-pushed the dic-tagged-prio-meth branch from 50ead19 to c1917c2 Compare October 2, 2019 15:30
@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Oct 2, 2019
@nicolas-grekas
feature #33628 [DependencyInjection] added Ability to define a priori…
67fe198 
…ty method for tagged service (lyrixx)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] added Ability to define a priority method for tagged service

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #32976
| License       | MIT
| Doc PR        |

Commits
-------

c1917c2 [DependencyInjection] added Ability to define a priority method for tagged service
@nicolas-grekas nicolas-grekas merged commit c1917c2 into symfony:4.4 Oct 2, 2019
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 2, 2019
Closed
@lyrixx lyrixx deleted the dic-tagged-prio-meth branch October 3, 2019 07:37
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
This was referenced Nov 12, 2019
Merged
Merged
@loic425 loic425 mentioned this pull request Jan 9, 2020
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 4, 2020
Closed
@aschempp aschempp mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[DI] Allow class-defined priority when using _instanceof + tags
5 participants
@lyrixx @nicolas-grekas @stof @yceruto @carsonbot