Add missing row_attr option to FormType #33688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should actually be added in BaseType, so that ButtonType also benefits from it, not only FormType. |
b7d6d9d to
d711ea2
Compare
|
Good catch, PR updated |
|
Noticed this while working on #33573. Didn't change it because I thought it was like this on purpose and it is justified for me to offer this feature only in the theme. But by looking at #30320, it's clear the initial idea was to add the form option as well. Not really a fan of adding another theming form option though. Also, if we had this one, why don't we add the others ? |
xabbuh
approved these changes
Sep 25, 2019
javiereguiluz
approved these changes
Sep 25, 2019
|
Thank you @mcsky. |
xabbuh
added a commit
that referenced
this pull request
Sep 25, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Add missing row_attr option to FormType | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix: #33682 - related issue #33573 | License | MIT The #33573 modified Symfony's form themes. But the [FormType](https://github.com/symfony/form/blob/master/Extension/Core/Type/FormType.php) don't allow the option `row_attr` so the OptionResolver throw an exception that the option is unknown. This PR basically add the option and give it to the form view (like `label_attr` do) Commits ------- d711ea2 Add missing row_attr option to FormType
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #33573 modified Symfony's form themes. But the FormType don't allow the option
row_attrso the OptionResolver throw an exception that the option is unknown.This PR basically add the option and give it to the form view (like
label_attrdo)