[Security] remove deprecated code paths #33697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 25, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
fabpot
approved these changes
Sep 25, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] remove deprecated code paths | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 2b6ce01 remove deprecated code paths
|
shouldn't the change be reflected in docblock? |
|
@ostrolucky Can you create a PR (targetting the |
jvasseur
reviewed
Sep 26, 2019
| } | ||
|
|
||
| return $this->accessDecisionManager->decide($token, $attributes, $subject); | ||
| return $this->accessDecisionManager->decide($token, (array) $attributes, $subject); |
There was a problem hiding this comment.
An array cast doesn't work here since $attributes can be an object, we could use [$attributes] instead since it can't be an array.
There was a problem hiding this comment.
only if $attributes is not null
would you mind sending a PR (with a test case ideally)?
There was a problem hiding this comment.
Even if $attributes is null, we should pass [null] to decide.
PR created : #33721
fabpot
added a commit
that referenced
this pull request
Sep 26, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Security] Fix isGranted with object attribute | Q | A | ------------- | --- | Branch? | master (the added test could be backported to older branches) | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #33697 (comment) | License | MIT | Doc PR | Fix calls to isGranted with `$attribute` beeing an object. Commits ------- 3a5fd48 Fix isGranted with object attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.