[String] renamed core classes to Byte/CodePoint/UnicodeString #33816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbc9b44 to
054e599
Compare
javiereguiluz
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
I like the new names a lot: ByteString and UnicodeString would be self-explanatory for most developers and only CodePointString would need some explanation for some people (but that's normal ... this is a "complex" topic, so developers need to learn some terminology).
yceruto
approved these changes
Oct 3, 2019
stof
reviewed
Oct 3, 2019
054e599 to
d54fd8d
Compare
d54fd8d to
63c105d
Compare
derrabus
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
I like the new naming. In the original PR, I especially found the name BinaryString problematic. If we look at the operations that this class allows, the class does not represent an arbitrary binary string, but a character string with some one-byte character encoding, e.g. ISO-8859-something. The new name reflects that better, imho.
nicolas-grekas
added a commit
that referenced
this pull request
Oct 7, 2019
…tring (nicolas-grekas) This PR was merged into the 5.0-dev branch. Discussion ---------- [String] renamed core classes to Byte/CodePoint/UnicodeString | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In #33553 there have been discussions about the naming of the classes - eg. "what's a grapheme", "why `Utf8String`", "lowercase on binary is weird", etc. What about these names? Would they get your votes *vs* the current ones? - `BinaryString` -> `ByteString` - `Utf8String` -> `CodePointString` - `GraphemeString` -> `UnicodeString` Commits ------- 63c105d [String] renamed core classes to Byte/CodePoint/UnicodeString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #33553 there have been discussions about the naming of the classes - eg. "what's a grapheme", "why
Utf8String", "lowercase on binary is weird", etc.What about these names? Would they get your votes vs the current ones?
BinaryString->ByteStringUtf8String->CodePointStringGraphemeString->UnicodeString