[FrameworkBundle] encourage installing intl when String is available #33825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 3, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
gharlan
suggested changes
Oct 3, 2019
8b4ce15 to
e5da792
Compare
tgalopin
approved these changes
Oct 3, 2019
yceruto
approved these changes
Oct 3, 2019
maxhelias
approved these changes
Oct 3, 2019
yceruto
reviewed
Oct 3, 2019
javiereguiluz
approved these changes
Oct 3, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 4, 2019
…is available (nicolas-grekas) This PR was merged into the 5.0-dev branch. Discussion ---------- [FrameworkBundle] encourage installing intl when String is available | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 215595b [FrameworkBundle] encourage installing intl when String is available
|
Unfortunately, this makes the |
|
We should skip the notice if |
|
Won't this only fix the tests? The intl extension will still be required if the String component is present. |
|
Not with polyfills - or did you spot something that is not polyfilled? |
|
Nope, I understand now :) |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 7, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #33868). Discussion ---------- Skip the intl notice if run with phpunit | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Re #33825 | License | MIT | Doc PR | - Commits ------- 25461b3 Skip the intl notice if run with phpunit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.