Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Intl] Update the ICU data to 65.1 #33852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Oct 4, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #33548
License MIT
Doc PR -

@jakzal
Copy link
Contributor Author

jakzal commented Oct 4, 2019

Status: needs work

Some intl-data tests are failing.

@ro0NL
Copy link
Contributor

ro0NL commented Oct 4, 2019

thanks :) (we should not forget to re-compile / run data tests per branch)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 4, 2019
@jakzal
Copy link
Contributor Author

jakzal commented Oct 4, 2019

status: needs review

All tests are passing now.

image

@jakzal jakzal changed the title WIP: [Intl] Update the ICU data to 65.1 [Intl] Update the ICU data to 65.1 Oct 4, 2019
@jakzal
Copy link
Contributor Author

jakzal commented Oct 4, 2019

Unfortunately, there will be lots of conflicts when merging this to 4.3. I'm fine to resolve them.

nicolas-grekas added a commit that referenced this pull request Oct 4, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] Update the ICU data to 65.1

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33548
| License       | MIT
| Doc PR        | -

Commits
-------

5cc9811 [Intl] Update the ICU data to 65.1
@nicolas-grekas nicolas-grekas merged commit 5cc9811 into symfony:3.4 Oct 4, 2019
@nicolas-grekas
Copy link
Member

Thank you @jakzal
I merged this PR in 3.4 then 4.3 but I ignored all conflicts.
PR welcome on 4.3 now.

@jakzal jakzal deleted the icu-65.1 branch October 4, 2019 20:00
@jakzal
Copy link
Contributor Author

jakzal commented Oct 4, 2019

On it! :)

nicolas-grekas added a commit that referenced this pull request Oct 4, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Intl] Update the ICU data to 65.1 (4.3 branch)

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fixes #33548
| License       | MIT
| Doc PR        | -

A follow up to #33852.

Commits
-------

1410f84 [Intl] Update the ICU data to 65.1 (4.3 branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants