Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip the intl notice if run with phpunit #33868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

Skip the intl notice if run with phpunit #33868

merged 1 commit into from
Oct 7, 2019

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Oct 5, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Re #33825
License MIT
Doc PR -

@jakzal
Copy link
Contributor Author

jakzal commented Oct 5, 2019

One more failure:

image

@jakzal
Copy link
Contributor Author

jakzal commented Oct 5, 2019

Build's green now :)

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Oct 7, 2019
@nicolas-grekas
Copy link
Member

Thank you @jakzal.

nicolas-grekas added a commit that referenced this pull request Oct 7, 2019
@nicolas-grekas
minor #33868 Skip the intl notice if run with phpunit (jakzal)
53f8627 
This PR was squashed before being merged into the 5.0-dev branch (closes #33868).

Discussion
----------

Skip the intl notice if run with phpunit

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Re #33825
| License       | MIT
| Doc PR        | -

Commits
-------

25461b3 Skip the intl notice if run with phpunit
@nicolas-grekas nicolas-grekas merged commit 25461b3 into symfony:master Oct 7, 2019
@jakzal jakzal deleted the build-fix branch October 7, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jakzal @nicolas-grekas @yceruto @maxhelias @carsonbot