Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] Improve the sorting of tagged services #33966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kr42
Copy link
Contributor

@Kr42 Kr42 commented Oct 12, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #33716
License MIT
Doc PR -

Little DX improvement, to sort the tags inside each service tagged.
More details in linked issue.

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a small comment.

@Kr42 Kr42 force-pushed the 33716-improve-sorting-tagged-services branch from ed82790 to 631e9ac Compare October 14, 2019 05:28
@Kr42 Kr42 force-pushed the 33716-improve-sorting-tagged-services branch from 631e9ac to f892289 Compare October 14, 2019 05:29
@nicolas-grekas
Copy link
Member

Thank you @krome162504.

nicolas-grekas added a commit that referenced this pull request Oct 14, 2019
…krome162504)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Improve the sorting of tagged services

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #33716
| License       | MIT
| Doc PR        | -

Little DX improvement, to sort the tags inside each service tagged.
More details in linked issue.

Commits
-------

f892289 [FrameworkBundle] Improve the sorting of tagged services
@nicolas-grekas nicolas-grekas merged commit f892289 into symfony:4.4 Oct 14, 2019
@Kr42 Kr42 deleted the 33716-improve-sorting-tagged-services branch October 15, 2019 05:46
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] Improve the sorting of tagged services
5 participants