[DI] add LazyString for lazy computation of string values injected into services
#34013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we support lazy-loading a service reference in a |
6bce16d to
aebd082
Compare
good idea, updated |
aebd082 to
ea7db68
Compare
yceruto
reviewed
Oct 17, 2019
ea7db68 to
516d9a9
Compare
|
(fabbot failure is false positive) |
yceruto
reviewed
Oct 17, 2019
516d9a9 to
bd260dd
Compare
yceruto
approved these changes
Oct 17, 2019
|
Could we do something similar, yet different, for string formatting? Some languages / libraries offer a string interpolation / formatting function which is lazily evaluated. An example use case is constructing a log message, which may or not be evaluated depending on the log level. |
|
@Devristo I feel like that's what this provides already: |
bd260dd to
dd413c8
Compare
dd413c8 to
ccb0365
Compare
fabpot
approved these changes
Oct 18, 2019
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 18, 2019
…alues injected into services (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] add `LazyString` for lazy computation of string values injected into services | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This is an idea I should have had years ago :) By wrapping any callable into a `LazyString`, we allow resolving the corresponding string value lazily (eg because the value comes from a remote server). The tricky parts are memoization and error handling, which are both dealt with in the class. This is currently part of #33997 Commits ------- ccb0365 [DI] add `LazyString` for lazy computation of string values injected into services
nicolas-grekas
added a commit
that referenced
this pull request
Oct 22, 2019
…s-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [EventDispatcher] handle lazy-callable invokable | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Extracted from #34013, for consistency mostly. Commits ------- 9df4c7d [EventDispatcher] handle lazy-callable invokable
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea I should have had years ago :)
By wrapping any callable into a
LazyString, we allow resolving the corresponding string value lazily (eg because the value comes from a remote server).The tricky parts are memoization and error handling, which are both dealt with in the class.
This is currently part of #33997