[Messenger] Fix ignored options in redis transport #34017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89c8715 to
c83ff94
Compare
There was a problem hiding this comment.
@chalasr should we clear the last error after getting it like we do it on other places?
alexander-schranz
approved these changes
Oct 18, 2019
nicolas-grekas
approved these changes
Oct 22, 2019
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 22, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Messenger] Fix ignored options in redis transport | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33425 | License | MIT | Doc PR | - Also fixes redis authentication failure handling (inline with invalid db index handling, borrowed from symfony/cache). /cc @alexander-schranz Commits ------- c83ff94 [Messenger] Fix ignored options in redis transport
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes redis authentication failure handling (inline with invalid db index handling, borrowed from symfony/cache).
/cc @alexander-schranz