[Console] Detect dimensions using mode CON if vt100 is supported #34085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @rtek. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 5, 2019
…ported (rtek) This PR was merged into the 4.3 branch. Discussion ---------- [Console] Detect dimensions using mode CON if vt100 is supported | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #33915 | License | MIT This fixes color support detection for users of Win10 + git-bash. If vt100 support is detected, the terminal will not try to use `stty` to test for dimensions. Calling such command implicitly disables vt100 support on STDOUT. Commits ------- fdeceff [Console] Fix #33915, Detect dimensions using mode CON if vt100 is supported
Merged
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Nov 13, 2019
…N if vt100 is supported This PR was merged into the 4.3 branch. Discussion ---------- [Console] Detect dimensions using mode CON if vt100 is supported | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#33915 | License | MIT This fixes color support detection for users of Win10 + git-bash. If vt100 support is detected, the terminal will not try to use `stty` to test for dimensions. Calling such command implicitly disables vt100 support on STDOUT. Commits ------- fdeceff [Console] Fix symfony#33915, Detect dimensions using mode CON if vt100 is supported
|
Should have been merged in 3.4, see #34346. |
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Nov 13, 2019
…N if vt100 is supported This PR was merged into the 4.3 branch. Discussion ---------- [Console] Detect dimensions using mode CON if vt100 is supported | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#33915 | License | MIT This fixes color support detection for users of Win10 + git-bash. If vt100 support is detected, the terminal will not try to use `stty` to test for dimensions. Calling such command implicitly disables vt100 support on STDOUT. Commits ------- fdeceff [Console] Fix symfony#33915, Detect dimensions using mode CON if vt100 is supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes color support detection for users of Win10 + git-bash. If vt100 support is detected, the terminal will not try to use
sttyto test for dimensions. Calling such command implicitly disables vt100 support on STDOUT.