Remove unused local variables #34105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Oct 24, 2019
| @@ -81,8 +89,10 @@ public function testConstructorThrowsExceptionIfNoRelatedForm() | |||
|
|
|||
| $nodes = $dom->getElementsByTagName('input'); | |||
|
|
|||
| $form = new Form($nodes->item(0), 'http://example.com'); | |||
| $form = new Form($nodes->item(1), 'http://example.com'); | |||
There was a problem hiding this comment.
The second one is never tested since the first one throws an exception.
yceruto
approved these changes
Oct 24, 2019
0f80fb6 to
b806624
Compare
b806624 to
c07cee8
Compare
fancyweb
commented
Oct 24, 2019
| @@ -130,7 +130,6 @@ public function update(Response $response) | |||
| $response->headers->set('Cache-Control', implode(', ', array_keys($flags))); | |||
|
|
|||
| $maxAge = null; | |||
| $sMaxage = null; | |||
There was a problem hiding this comment.
$sMaxage is assigned line 140 and only used in the if.
fancyweb
commented
Oct 24, 2019
| @@ -49,7 +49,6 @@ public function collect(Request $request, Response $response, \Exception $except | |||
| } | |||
| } | |||
|
|
|||
| $content = null; | |||
There was a problem hiding this comment.
$content is directly assigned in the try and in the catch and there is not check on it.
fancyweb
commented
Oct 24, 2019
| @@ -59,7 +58,6 @@ public function collect(Request $request, Response $response, \Exception $except | |||
|
|
|||
| $sessionMetadata = []; | |||
| $sessionAttributes = []; | |||
| $session = null; | |||
There was a problem hiding this comment.
$session is assigned line 63 and only used in the if.
fancyweb
commented
Oct 24, 2019
| @@ -196,7 +196,7 @@ public function testCachingWithDifferentNamesOrder() | |||
| $cacheMock = $this->getMockBuilder('Psr\Cache\CacheItemPoolInterface')->getMock(); | |||
| $cacheItemMock = $this->getMockBuilder('Psr\Cache\CacheItemInterface')->getMock(); | |||
| $expressionLanguage = new ExpressionLanguage($cacheMock); | |||
| $savedParsedExpressions = []; | |||
| $savedParsedExpression = null; | |||
There was a problem hiding this comment.
This one is a fix on the test.
fancyweb
commented
Oct 24, 2019
| @@ -219,7 +219,7 @@ public function dump(array $options = []) | |||
| foreach ($ids as $id) { | |||
| $c .= ' '.$this->doExport($id)." => true,\n"; | |||
| } | |||
| $files['removed-ids.php'] = $c .= "];\n"; | |||
There was a problem hiding this comment.
The resulting $c is never reused so the assignation is useless.
fancyweb
commented
Oct 24, 2019
| @@ -404,7 +404,7 @@ private function darwinRealpath($real) | |||
| } | |||
|
|
|||
| if (isset($dirFiles[$file])) { | |||
| return $real .= $dirFiles[$file]; | |||
There was a problem hiding this comment.
Returning an assignation is useless, $real is not passed by ref.
fancyweb
commented
Oct 24, 2019
| @@ -1043,8 +1043,6 @@ private function registerAssetsConfiguration(array $config, ContainerBuilder $co | |||
| $container->getDefinition('assets.url_package')->setPrivate(true); | |||
| $container->getDefinition('assets.static_version_strategy')->setPrivate(true); | |||
|
|
|||
| $defaultVersion = null; | |||
There was a problem hiding this comment.
$defaultVersion is always assigned in the if else block.
fancyweb
commented
Oct 24, 2019
| @@ -425,7 +425,6 @@ private function renderEventListenerTable(EventDispatcherInterface $eventDispatc | |||
| $tableHeaders = ['Order', 'Callable', 'Priority']; | |||
| $tableRows = []; | |||
|
|
|||
| $order = 1; | |||
There was a problem hiding this comment.
$order is directly reassigned by the foreach.
fancyweb
commented
Oct 24, 2019
| @@ -28,7 +28,6 @@ public function compile(Compiler $compiler) | |||
|
|
|||
| preg_match('/_([^_]+)$/', $this->getAttribute('name'), $matches); | |||
|
|
|||
| $label = null; | |||
There was a problem hiding this comment.
$label is assigned line 42 and only used in this code path.
fancyweb
commented
Oct 24, 2019
| @@ -132,9 +132,6 @@ public function testFindProcessInOpenBasedir() | |||
| $this->assertSamePath(PHP_BINARY, $result); | |||
| } | |||
|
|
|||
| /** | |||
| * @requires PHP 5.4 | |||
There was a problem hiding this comment.
Min PHP version is 5.5.9.
yceruto
approved these changes
Oct 24, 2019
Tobion
approved these changes
Oct 25, 2019
|
Thank you @fancyweb. |
Tobion
added a commit
that referenced
this pull request
Oct 25, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Remove unused local variables | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR removes useless assignations. There are also somes fixes in tests. Commits ------- c07cee8 Remove unused local variables in tests
nicolas-grekas
added a commit
that referenced
this pull request
Oct 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #34105 on 4.3. Commits ------- 58161b8 [4.3] Remove unused local variables
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
Oct 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony/symfony#34105 on 4.3. Commits ------- 58161b8eec [4.3] Remove unused local variables
symfony-splitter
pushed a commit
to symfony/security-bundle
that referenced
this pull request
Oct 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony/symfony#34105 on 4.3. Commits ------- 58161b8eec [4.3] Remove unused local variables
symfony-splitter
pushed a commit
to symfony/http-client
that referenced
this pull request
Oct 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony/symfony#34105 on 4.3. Commits ------- 58161b8eec [4.3] Remove unused local variables
symfony-splitter
pushed a commit
to symfony/config
that referenced
this pull request
Oct 30, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony/symfony#34105 on 4.3. Commits ------- 58161b8eec [4.3] Remove unused local variables
sadafrangian3
pushed a commit
to sadafrangian3/Dependency-Injection-http-client
that referenced
this pull request
Nov 2, 2022
This PR was merged into the 4.3 branch. Discussion ---------- [4.3] Remove unused local variables | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of symfony/symfony#34105 on 4.3. Commits ------- 58161b8eec [4.3] Remove unused local variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes useless assignations. There are also somes fixes in tests.