[Serializer] Use context to compute MetadataAwareNameConverter cache #34246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33a3953 to
c8311ee
Compare
src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php
Outdated
Show resolved
Hide resolved
c8311ee to
57eb533
Compare
|
Thanks for your review @nicolas-grekas , I've updated all points as requested and rebased |
57eb533 to
0ac5346
Compare
|
Thank you @antograssiot. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2019
…rter cache (antograssiot) This PR was merged into the 4.3 branch. Discussion ---------- [Serializer] Use context to compute MetadataAwareNameConverter cache | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This is a follow up PR to #34035 to address @nicolas-grekas 's [comment](#34035 (comment)) The static cache has been re-introduced and the context is used to compute the cache key used for denormalization Commits ------- 0ac5346 [Serializer] Use context to compute MetadataAwareNameConverter cache
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #34035 to address @nicolas-grekas 's comment
The static cache has been re-introduced and the context is used to compute the cache key used for denormalization