more strict requirements of experimental components #34316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 11, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
| @@ -79,8 +79,10 @@ | |||
| "symfony/mailer": "<4.4", | |||
| "symfony/messenger": "<4.4", | |||
| "symfony/mime": "<4.4", | |||
| "symfony/notifier": ">=5.1", | |||
There was a problem hiding this comment.
We register services for the Notifier component in FrameworkExtension::registerNotifierConfiguration().
There was a problem hiding this comment.
I'm reverting the conflicts here, they make composer unable to resolve deps.
There was a problem hiding this comment.
yeah, that's because dev-master branches that conflict rule (see composer/composer#8323 where I suggest we should change it in composer 2)
There was a problem hiding this comment.
So we should re-revert this before the release of Symfony 5.
There was a problem hiding this comment.
I think we don't need to. IF there is some conflict to add, we will add it to the components 5.1
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2019
…buh) This PR was merged into the 5.0-dev branch. Discussion ---------- more strict requirements of experimental components | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 23bc40b more strict requirements of experimental components
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 17, 2019
…grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- Relax requirements for experimental components | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Reverts #34316 for 5.1 only. Commits ------- 0c1c4ed Relax requirements for experimental components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.