[ExpressionLanguage] add XOR operator #34329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Nov 12, 2019
a6cecd8 to
46fe917
Compare
|
Thank you @ottaviano. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [ExpressionLanguage] add XOR operator | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ 👋 little PR for adding the best logical operator: `XOR` Commits ------- 46fe917 [ExpressionLanguage] add XOR operator
|
I'm against this addition. I made a conscious decision to not add such an operator to ExpressionLanguage. |
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Nov 12, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2019
…erator (ottaviano)" (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This reverts commit d1d4bc8, reversing changes made to f63976f. Commits ------- adb716d Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)"
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2019
* 4.4: Revert "feature #34329 [ExpressionLanguage] add XOR operator (ottaviano)" Allow \Throwable $previous everywhere
|
@fabpot, ah, I did not find any issue/discussion on this. It would be nice to know the reason. thanks |
This was referenced Nov 12, 2019
Merged
Merged
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
* 4.4: Revert "feature symfony#34329 [ExpressionLanguage] add XOR operator (ottaviano)" Allow \Throwable $previous everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
little PR for adding the best logical operator:
XOR