[TwigBridge] form button title attr will now trans for button without text #34436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n if its label is null or false
bykclk
approved these changes
Nov 18, 2019
darielopper
approved these changes
Nov 18, 2019
src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
Outdated
Show resolved
Hide resolved
No good reason, only inexperience with contributing. Should I convert the PR to a bug fix and move the commit to a branch off 3.4? (I'll play around locally to figure out how to do that...) |
|
Recreated as bugfix in 3.4 (PR #35193). Same changes as above, no issues found. Apologies if this is the wrong way to change the PR type; if there is a better way, I'd appreciate feedback :-) |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2020
…ed even if its label = null or false (stephen-lewis) This PR was squashed before being merged into the 3.4 branch (closes #35193). Discussion ---------- [TwigBridge] button_widget now has its title attr translated even if its label = null or false | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34330 | License | MIT | Doc PR | TODO Duplicate of #34436 but changed to bugfix and applied to 3.4. Buttons with null or false 'label' options will now have their 'title' attribute translated against the current translation domain. Commits ------- 2a5d9cb [TwigBridge] button_widget now has its title attr translated even if its label = null or false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons with null or false 'label' options will now have their 'title' attribute translated against the current translation domain.