[Form][ButtonBuilder] Prevent buttons names from starting with a capital letter #34445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8855026 to
fe82230
Compare
fe82230 to
5c843ff
Compare
|
Actually it was missing in #31705 |
darielopper
approved these changes
Nov 18, 2019
5c843ff to
8676a9d
Compare
8676a9d to
0eab1fd
Compare
|
Looking back in the history of changes it seems to me that was a mistake in #28969 to deprecate names starting with uppercase letters. |
|
Just saw #34448. Closing here then 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @xabbuh.
It was forbidden in #28969 but it does not throw in 5.0 as it should.
We cannot use
FormConfigBuilder::validateName()inButtonBuilderbecause this one allows first capital letters. We cannot change it because form names can start with capital letters (it is currently not deprecated in 4.4).So we either also deprecate this (but why?) or we just validate button names in its own builder (proposed change in this PR).