[Form] group constraints when calling the validator #34464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d571d2f to
d15f77f
Compare
xabbuh
approved these changes
Nov 20, 2019
ogizanagi
approved these changes
Nov 20, 2019
| @@ -97,6 +99,10 @@ public function validate($form, Constraint $formConstraint) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| foreach ($groupedConstraints as $group => $constraint) { | |||
There was a problem hiding this comment.
- constraint
+ constraints?
There was a problem hiding this comment.
That would override the $constraints variable used above.
There was a problem hiding this comment.
Maybe name it $constraintsInGroup or so? Slightly confusing otherwise 🙈
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2019
…as-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Form] group constraints when calling the validator | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follow up of #34081 Spotted during the workshop at SymfonyCon, while trying to fix deprecation notices on symfony-demo: the Form component currently passes constraints one by one for validation, effectively preventing the validator from taking care of cross-constraints dependencies. This PR fixes it. This will prevent ppl from having to fix things like > Using the "Symfony\Component\Validator\Constraints\Length" constraint with the "min" option without setting the "allowEmptyString" one is deprecated and defaults to true. In 5.0, it will become optional and default to false. Commits ------- d15f77f [Form] group constraints when calling the validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #34081
Spotted during the workshop at SymfonyCon, while trying to fix deprecation notices on symfony-demo:
the Form component currently passes constraints one by one for validation, effectively preventing the validator from taking care of cross-constraints dependencies.
This PR fixes it.
This will prevent ppl from having to fix things like