Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DoctrineBridge] Fixed DoctrineType::reset to handle IdReaders #34609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[DoctrineBridge] Fixed DoctrineType::reset to handle IdReaders #34609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[DoctrineBridge] Fixed DoctrineType::reset to handle IdReaders
  • Loading branch information
@HeahDude
HeahDude committed Nov 25, 2019
commit 20911b5c7d0c74a155248e1f1ae3ff4e07cc2dc6
1 change: 1 addition & 0 deletions src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ public function getParent()

public function reset()
{
$this->idReaders = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh: won't this prevent caching between requests thus reduce perf while it's not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the readers are not depending on the request context, nor time sensitive. Closing here.

$this->choiceLoaders = [];
}
}