[Routing] Continue supporting single colon in object route loaders #34621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b527ef to
c9035f6
Compare
c9035f6 to
3c796e1
Compare
nicolas-grekas
approved these changes
Nov 26, 2019
fabpot
approved these changes
Nov 26, 2019
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2019
… loaders (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Continue supporting single colon in object route loaders | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34612 | License | MIT | Doc PR | - #32582 (comment) was a bad idea. The new `ObjectLoader` class is used directly on 4.4 since we detagged the old service (and the old one). So we need to support the old notation on it. It changes the exception message but it should be alright. Commits ------- 3c796e1 [Routing] Continue supporting single colon in object route loaders
fabpot
added a commit
that referenced
this pull request
Dec 4, 2019
… merge (fancyweb) This PR was merged into the 5.0 branch. Discussion ---------- [Routing][ObjectLoader] Remove forgotten deprecation after merge | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - #34621 needs to be gone on 5.0. We want to throw here. I think it was forgotten when merging in 5.0. Commits ------- 4e60b9d [Routing][ObjectLoader] Remove forgotten deprecation after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32582 (comment) was a bad idea. The new
ObjectLoaderclass is used directly on 4.4 since we detagged the old service (and the old one). So we need to support the old notation on it. It changes the exception message but it should be alright.