[SecurityBundle] Use config variable in AnonymousFactory #34786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was incorrectly copied in PR symfony#33503
nicolas-grekas
approved these changes
Dec 3, 2019
|
Thank you @martijnboers. |
chalasr
pushed a commit
that referenced
this pull request
Dec 3, 2019
…martijnboers) This PR was merged into the 4.4 branch. Discussion ---------- [SecurityBundle] Use config variable in AnonymousFactory | Q | A | ------------- | --- | Branch? | 4.4 and 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT It looks like the `AnonymousFactory` was copied incorrectly in #33503 as it uses the old `$firewall` variable available in `SecurityExtension.php`. Changing this to `$config` yields the desired results Commits ------- 8d850d2 When set, get secret from config variable
|
And congratz for your first contrib :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
AnonymousFactorywas copied incorrectly in #33503 as it uses the old$firewallvariable available inSecurityExtension.php. Changing this to$configyields the desired results