[HttpFoundation] get currently session.gc_maxlifetime if ttl doesnt exists #34827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbeek
approved these changes
Dec 5, 2019
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/RedisSessionHandler.php
Outdated
Show resolved
Hide resolved
|
@nicolas-grekas is it ok? |
|
Thank you @rafaeltovar. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 6, 2019
…tl doesnt exists (rafaeltovar) This PR was submitted for the master branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- [HttpFoundation] get currently session.gc_maxlifetime if ttl doesnt exists | Q | A | ------------- | --- | Branch? | master / 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34659 | License | MIT If option `ttl` was not defined in RedisSessionHandler, this got the default `session.gc_maxlifetime`. With this fixed, RedisSessionHandler get the currently `session.gc_maxlifetime`. Commits ------- b6253e2 [HttpFoundation] get currently session.gc_maxlifetime if ttl doesnt exists
|
You're welcome @nicolas-grekas :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If option
ttlwas not defined in RedisSessionHandler, this got the defaultsession.gc_maxlifetime. With this fixed, RedisSessionHandler get the currentlysession.gc_maxlifetime.