[FrameworkBundle] Fix invalid Windows path normalization in TemplateNameParser #34915
Conversation
|
Could you please add a test case? |
|
I just updated the existing tests. Absolute path support has been removed in Symfony 4.0, so this PR should be:
|
|
Could this class help in this case? |
No, the mentioned PR does not update the destructive change done at this line https://github.com/symfony/symfony/pull/34915/files#diff-b696dd35180a8539992b7a209a0c9defL47 in any way. |
|
@nicolas-grekas Tests updated, see above, can you please review and merge? |
There was a problem hiding this comment.
This str_replace() dates back to 22aba90 but I fail to see why it's here now.
The changes on the tests LGTM.
|
Thank you @mvorisek. |
…n TemplateNameParser (mvorisek) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix invalid Windows path normalization in TemplateNameParser | Q | A | ------------- | --- | Branch? | 3.4 - <5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | Fix invalid Windows path normalization All versions of Symfony until 5.0 (which does no longer do extra file path normalization) normalize Windows paths wrongly. See PrestaShop/PrestaShop#16736 and https://bugs.php.net/bug.php?id=78939 Currently this issue can be observed when Symfony is run by NTS PHP only, but once the PHP issue will be fixed, this issue will probably affects all Windows users when absolute template name is passed to Symfony templating. Commits ------- 130df8c Fix invalid Windows path normalization
|
Will this PR be merged into 3.4 and develop branch as well and when is the next 3.4 release planned? Is it ok to delete the fork before the PR is merged in all branches? |
|
it’s fine to delete the fork as it’s already merged in 3.4 upstream branch |
All versions of Symfony until 5.0 (which does no longer do extra file path normalization) normalize Windows paths wrongly.
See PrestaShop/PrestaShop#16736 and https://bugs.php.net/bug.php?id=78939
Currently this issue can be observed when Symfony is run by NTS PHP only, but once the PHP issue will be fixed, this issue will probably affects all Windows users when absolute template name is passed to Symfony templating.