Require doctrine/persistence ^1.3 #34955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61c1d96 to
7af8eda
Compare
alcaeus
reviewed
Dec 12, 2019
| @@ -19,7 +19,7 @@ | |||
| "php": "^7.1.3", | |||
| "ext-xml": "*", | |||
| "doctrine/event-manager": "~1.0", | |||
| "doctrine/persistence": "~1.0", | |||
| "doctrine/persistence": "^1.3", | |||
There was a problem hiding this comment.
This should be ^1.3 || ^2.0 - we're looking for absolute parity between the two versions.
There was a problem hiding this comment.
that would prevent testing with 1.3 for now
OK in a later PR
7af8eda to
f2edc7b
Compare
alcaeus
approved these changes
Dec 12, 2019
f2edc7b to
ce5dcb9
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Require doctrine/persistence ^1.3 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This is the only way to remove direct deprecations triggered by doctrine/persistence ^1.3. Requires v1.3.0 to be tagged before the next bug fix release. /cc @alcaeus The only deprecations that remain are triggered by the ORM now. Commits ------- ce5dcb9 Require doctrine/persistence ^1.3
|
@nicolas-grekas maybe this breaks stuff :D |
|
sorry, this is unreleased. So a BC break on Doctrine's side. |
|
@ro0NL this PR did not introduce the issue, but here is the fix anyway: doctrine/persistence#82 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only way to remove direct deprecations triggered by doctrine/persistence ^1.3.
Requires v1.3.0 to be tagged before the next bug fix release.
/cc @alcaeus
The only deprecations that remain are triggered by the ORM now.