Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[EventDispatcher] Deprecate LegacyEventDispatcherProxy #34977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2019
Merged

[EventDispatcher] Deprecate LegacyEventDispatcherProxy #34977

merged 1 commit into from
Dec 16, 2019

Conversation

derrabus
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? yes
Tickets Cleanup of #28920
License MIT
Doc PR N/A

This class should be deprecated in Symfony 5.1

Well, here you go. 😃

@derrabus derrabus requested a review from sroze as a code owner December 13, 2019 21:49
@derrabus derrabus force-pushed the improvement/deprecate-legacy-ed-proxy branch from f17d2ec to 540e13b Compare December 13, 2019 21:51
derrabus
derrabus commented Dec 13, 2019
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the next milestone Dec 15, 2019
nicolas-grekas
nicolas-grekas reviewed Dec 15, 2019
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Dec 15, 2019
View reviewed changes
@derrabus derrabus force-pushed the improvement/deprecate-legacy-ed-proxy branch 3 times, most recently from 91a0760 to 6bf5f4e Compare December 15, 2019 21:28
nicolas-grekas
nicolas-grekas reviewed Dec 15, 2019
View reviewed changes
@derrabus derrabus force-pushed the improvement/deprecate-legacy-ed-proxy branch from 6bf5f4e to d3f1289 Compare December 15, 2019 22:53
@derrabus derrabus force-pushed the improvement/deprecate-legacy-ed-proxy branch from d3f1289 to c7e612d Compare December 15, 2019 22:54
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

nicolas-grekas added a commit that referenced this pull request Dec 16, 2019
@nicolas-grekas
feature #34977 [EventDispatcher] Deprecate LegacyEventDispatcherProxy…
c8f3053 
… (derrabus)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[EventDispatcher] Deprecate LegacyEventDispatcherProxy

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | Cleanup of #28920
| License       | MIT
| Doc PR        | N/A

> This class should be deprecated in Symfony 5.1

Well, here you go. 😃

Commits
-------

c7e612d [EventDispatcher] Deprecate LegacyEventDispatcherProxy.
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 16, 2019
Closed
@nicolas-grekas nicolas-grekas merged commit c7e612d into symfony:master Dec 16, 2019
@derrabus derrabus deleted the improvement/deprecate-legacy-ed-proxy branch December 16, 2019 13:05
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@chalasr chalasr chalasr approved these changes

@darielopper darielopper darielopper approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Deprecation EventDispatcher Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @nicolas-grekas @chalasr @darielopper @carsonbot