Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stop using deprecated Doctrine persistence classes #34981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2019
Merged

stop using deprecated Doctrine persistence classes #34981

merged 1 commit into from
Dec 15, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 14, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Dec 14, 2019
@xabbuh xabbuh marked this pull request as ready for review December 14, 2019 20:24
@xabbuh xabbuh force-pushed the doctrine-persistence branch from 1db98fd to 4db5f02 Compare December 15, 2019 07:53
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request Dec 15, 2019
@nicolas-grekas
bug #34981 stop using deprecated Doctrine persistence classes (xabbuh)
2b40bb4 
This PR was merged into the 3.4 branch.

Discussion
----------

stop using deprecated Doctrine persistence classes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

4db5f02 stop using deprecated Doctrine persistence classes
@nicolas-grekas nicolas-grekas merged commit 4db5f02 into symfony:3.4 Dec 15, 2019
@xabbuh xabbuh deleted the doctrine-persistence branch December 15, 2019 09:59
This was referenced Dec 19, 2019
Merged
Merged
@gmponos
Copy link
Contributor

gmponos commented Dec 20, 2019

I still get deprecations

image

> composer show | grep symfony -i

symfony/asset                                               v5.0.2             Symfony Asset Component
symfony/browser-kit                                         v5.0.2             Symfony BrowserKit Component
symfony/cache                                               v5.0.2             Symfony Cache component with PSR-6, PSR-16, and tags
symfony/cache-contracts                                     v2.0.1             Generic abstractions related to caching
symfony/config                                              v5.0.2             Symfony Config Component
symfony/console                                             v5.0.2             Symfony Console Component
symfony/css-selector                                        v5.0.2             Symfony CssSelector Component
symfony/debug-bundle                                        v5.0.2             Symfony DebugBundle
symfony/dependency-injection                                v5.0.2             Symfony DependencyInjection Component
symfony/doctrine-bridge                                     v5.0.2             Symfony Doctrine Bridge
symfony/dom-crawler                                         v5.0.2             Symfony DomCrawler Component
symfony/dotenv                                              v5.0.2             Registers environment variables from a .env file
symfony/error-handler                                       v5.0.2             Symfony ErrorHandler Component
symfony/event-dispatcher                                    v5.0.2             Symfony EventDispatcher Component
symfony/event-dispatcher-contracts                          v2.0.1             Generic abstractions related to dispatching event
symfony/expression-language                                 v5.0.2             Symfony ExpressionLanguage Component
symfony/filesystem                                          v5.0.2             Symfony Filesystem Component
symfony/finder                                              v5.0.2             Symfony Finder Component
symfony/flex                                                v1.6.0             Composer plugin for Symfony
symfony/form                                                v5.0.2             Symfony Form Component
symfony/framework-bundle                                    v5.0.2             Symfony FrameworkBundle
symfony/http-foundation                                     v5.0.2             Symfony HttpFoundation Component
symfony/http-kernel                                         v5.0.2             Symfony HttpKernel Component
symfony/inflector                                           v5.0.2             Symfony Inflector Component
symfony/intl                                                v5.0.2             A PHP replacement layer for the C intl extension that includes additional data from the ICU library.
symfony/maker-bundle                                        v1.14.3            Symfony Maker helps you create empty commands, controllers, form classes, tests and more so you can forget about writing...
symfony/messenger                                           v5.0.2             Symfony Messenger Component
symfony/mime                                                v5.0.2             A library to manipulate MIME messages
symfony/monolog-bridge                                      v5.0.2             Symfony Monolog Bridge
symfony/monolog-bundle                                      v3.5.0             Symfony MonologBundle
symfony/options-resolver                                    v5.0.2             Symfony OptionsResolver Component
symfony/polyfill-ctype                                      v1.13.1            Symfony polyfill for ctype functions
symfony/polyfill-intl-icu                                   v1.13.1            Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn                                   v1.13.1            Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-mbstring                                   v1.13.1            Symfony polyfill for the Mbstring extension
symfony/polyfill-php72                                      v1.13.1            Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73                                      v1.13.1            Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/process                                             v5.0.2             Symfony Process Component
symfony/property-access                                     v5.0.2             Symfony PropertyAccess Component
symfony/proxy-manager-bridge                                v5.0.2             Symfony ProxyManager Bridge
symfony/routing                                             v5.0.2             Symfony Routing Component
symfony/security-bundle                                     v5.0.2             Symfony SecurityBundle
symfony/security-core                                       v5.0.2             Symfony Security Component - Core Library
symfony/security-csrf                                       v5.0.2             Symfony Security Component - CSRF Library
symfony/security-guard                                      v5.0.2             Symfony Security Component - Guard
symfony/security-http                                       v5.0.2             Symfony Security Component - HTTP Integration
symfony/serializer                                          v5.0.2             Symfony Serializer Component
symfony/service-contracts                                   v2.0.1             Generic abstractions related to writing services
symfony/stopwatch                                           v5.0.2             Symfony Stopwatch Component
symfony/swiftmailer-bundle                                  v3.4.0             Symfony SwiftmailerBundle
symfony/translation                                         v5.0.2             Symfony Translation Component
symfony/translation-contracts                               v2.0.1             Generic abstractions related to translation
symfony/twig-bridge                                         v5.0.2             Symfony Twig Bridge
symfony/twig-bundle                                         v5.0.2             Symfony TwigBundle
symfony/validator                                           v5.0.2             Symfony Validator Component
symfony/var-dumper                                          v5.0.2             Symfony mechanism for exploring and dumping PHP variables
symfony/var-exporter                                        v5.0.2             A blend of var_export() + serialize() to turn any serializable data structure to plain PHP code
symfony/web-profiler-bundle                                 v5.0.2             Symfony WebProfilerBundle
symfony/webpack-encore-bundle                               v1.7.2             Integration with your Symfony app & Webpack Encore!
symfony/yaml                                                v5.0.2             Symfony Yaml Component

Are the deprecations fixed here only some of them?

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 20, 2019 •
edited
Loading

@gmponos please have a look at the stack trace and report the deprecations to the project(s) that triggers them. That's not Symfony anymore.

@stof
Copy link
Member

stof commented Dec 20, 2019

these are not from Symfony, but from the Doctrine ORM (where this work is in progress)

@gmponos
Copy link
Contributor

gmponos commented Dec 20, 2019

thank you sorry for the noise..

@protracks
Copy link

I get these depreciations right after a composer update, but when i do php bin/console cache:clear they go away?

@nicolas-grekas
Copy link
Member

I'm locking this PR because the issue is fixed and deprecations from doctrine/orm or any other package are not ours to handle. Please ask on the appropriate repositories.

@symfony symfony locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @nicolas-grekas @gmponos @stof @protracks @carsonbot