[Console][SymfonyQuestionHelper] Handle multibytes question choices keys and custom prompt #35000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eys and custom prompt Co-authored-by: Mikhail Fesenko <[email protected]>
d8a7d32 to
f175032
Compare
nicolas-grekas
approved these changes
Dec 17, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2019
…n choices keys and custom prompt (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Console][SymfonyQuestionHelper] Handle multibytes question choices keys and custom prompt | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #33928 | License | MIT | Doc PR | - Replaces / finishes #33911 Commits ------- f175032 [Console][SymfonyQuestionHelper] Handle multibytes question choices keys and custom prompt
|
And thank you @proggga, you are co author of this work 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces / finishes #33911