[TwigBridge] Fix invalid typehint for subject in is_granted Twig function #35028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 18, 2019
stof
approved these changes
Dec 18, 2019
|
Thank you @emodric. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2019
…d Twig function (emodric) This PR was merged into the 5.0 branch. Discussion ---------- [TwigBridge] Fix invalid typehint for subject in is_granted Twig function | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35026 | License | MIT | Doc PR | N/A Twig function `is_granted` does not accept `mixed` any more for its second argument, instead requiring `object` or `null` with a PHP typehint. `AuthorizationCheckerInterface::isGranted`, where this argument is passed, has no typehint in code and is typehinted as `mixed` in PHPDoc. This makes it impossible to have a check in Twig template with code similar to this: `{% if is_granted('ROLE_MY_APP', {foo: 'bar', bar: 'baz'}) %}...{% endif %}` Commits ------- d3d86ce Fix invalid typehint for subject in is_granted Twig function
emodric
added a commit
to netgen-layouts/layouts-core
that referenced
this pull request
Dec 19, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twig function
is_granteddoes not acceptmixedany more for its second argument, instead requiringobjectornullwith a PHP typehint.AuthorizationCheckerInterface::isGranted, where this argument is passed, has no typehint in code and is typehinted asmixedin PHPDoc.This makes it impossible to have a check in Twig template with code similar to this:
{% if is_granted('ROLE_MY_APP', {foo: 'bar', bar: 'baz'}) %}...{% endif %}