[FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr #35170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe not relevant for this specific command, but outputting informational messages on stderr is often quite legit: when the command produces technically useful output (compared to info messages which are useful only for human readers), then these should be split to stdout/stderr. |
src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
Outdated
Show resolved
Hide resolved
Because all other commands output this kind of things on stdout which seems better to me. Let's be consistent. |
f5e0d81 to
87212e4
Compare
nicolas-grekas
approved these changes
Jan 6, 2020
yceruto
approved these changes
Jan 6, 2020
chalasr
approved these changes
Jan 6, 2020
fabpot
approved these changes
Jan 7, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2020
…positive feedback on stderr (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #34865 (comment) | License | MIT | Doc PR | - Outputing everything on stderr seems wrong. I'm going to check upper branches. Commits ------- 87212e4 [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputing everything on stderr seems wrong. I'm going to check upper branches.