[Mailer][MailchimpBridge] Fix incorrect sender address when sender has name #35172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s name This fixes the same problem as symfony@6dbac13 but for HTTP transport.
fabpot
approved these changes
Jan 2, 2020
|
Thank you @vilius-g. |
fabpot
added a commit
that referenced
this pull request
Jan 2, 2020
…n sender has name (vilius-g) This PR was merged into the 4.3 branch. Discussion ---------- [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This fixes the same problem as 6dbac13 but for HTTP transport. I am also not sure that `from_email` parameter is needed here at all as it is optional for this API call. Commits ------- 9e12a6d [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
This was referenced Jan 21, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the same problem as 6dbac13 but for HTTP transport.
I am also not sure that
from_emailparameter is needed here at all as it is optional for this API call.