[TwigBridge] button_widget now has its title attr translated even if its label = null or false #35193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 4, 2020
fabpot
approved these changes
Jan 7, 2020
…its label = null or false
80b4f6a to
2a5d9cb
Compare
|
Thank you @stephen-lewis. |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2020
…ed even if its label = null or false (stephen-lewis) This PR was squashed before being merged into the 3.4 branch (closes #35193). Discussion ---------- [TwigBridge] button_widget now has its title attr translated even if its label = null or false | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34330 | License | MIT | Doc PR | TODO Duplicate of #34436 but changed to bugfix and applied to 3.4. Buttons with null or false 'label' options will now have their 'title' attribute translated against the current translation domain. Commits ------- 2a5d9cb [TwigBridge] button_widget now has its title attr translated even if its label = null or false
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #34436 but changed to bugfix and applied to 3.4. Buttons with null or false 'label' options will now have their 'title' attribute translated against the current translation domain.