[FrameworkBundle] Set booted flag to false when test kernel is unset #35323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @thiagocordeiro. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 14, 2020
…l is unset (thiagocordeiro) This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead. Discussion ---------- [FrameworkBundle] Set booted flag to false when test kernel is unset | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT When `KernelTestCase::$kernel` is set to `null` `KernelTestCase::$booted` is not reseted and recreating the client is not possible because it relies on `booted` flag Commits ------- 6f4684f Set booted flag to false when test kernel is unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
KernelTestCase::$kernelis set tonullKernelTestCase::$bootedis not reseted and recreating the client is not possible because it relies onbootedflag