[DI] Fix EnvVar not loaded when Loader requires an env var #35355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c11ff3f to
c371297
Compare
cc1849a to
85d2f05
Compare
85d2f05 to
95ced71
Compare
95ced71 to
e119aa6
Compare
nicolas-grekas
approved these changes
Jan 20, 2020
|
Good catch, thanks @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 20, 2020
… (jderusse) This PR was merged into the 4.4 branch. Discussion ---------- [DI] Fix EnvVar not loaded when Loader requires an env var | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #35348 | License | MIT | Doc PR | NA When an EnvVarLoader has a dependency on an Env Var tried to be loaded (which is the case for SodiumVault that is configured with `default::SYMFONY_DECRYPTION_SECRET`) the Loader is not usable. What happens: - when trying to resolve `SYMFONY_DECRYPTION_SECRET`, the EnvVarProcessor iterates over loaders - given SodiumVaultLoaders requires the same env variable `SYMFONY_DECRYPTION_SECRET`, it throws a `ParameterCircularReferenceException` - letting the $loaders generator invalid This PR, refactor the way loaders are iterated in order to rewind on failure. Commits ------- e119aa6 [DI] Fix EnvVar not loaded when Loader requires an env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an EnvVarLoader has a dependency on an Env Var tried to be loaded (which is the case for SodiumVault that is configured with
default::SYMFONY_DECRYPTION_SECRET) the Loader is not usable.What happens:
SYMFONY_DECRYPTION_SECRET, the EnvVarProcessor iterates over loadersSYMFONY_DECRYPTION_SECRET, it throws aParameterCircularReferenceExceptionThis PR, refactor the way loaders are iterated in order to rewind on failure.