[WebProfilerBundle] Add an HTML comment to specify the Symfony toolbar on the body tag #35372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arman-Hosseini
commented
Jan 17, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| License | MIT |
|
what does it solve? |
|
I think that |
When the user sees the html source - will find that it belongs to Symfony toolbar. |
|
i still dont see what problem it solves :) usually you inspect elements from the UI/console perspective. id argue looking at raw HTML is a common thing for debugging, unless you know what you're looking for already. i.e. #31514 described a much more real life problem. |
|
I'm also not convinced that this is needed (in any case, that could not go in 3.4). Let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.