Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] fix ldap_bind service arguments #35438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2020
Merged

[SecurityBundle] fix ldap_bind service arguments #35438

merged 1 commit into from
Jan 27, 2020

Conversation

Ioni14
Copy link
Contributor

@Ioni14 Ioni14 commented Jan 22, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT

The 6th argument of LdapBindAuthenticationProvider was not correctly set in the service declaration security_listeners.xml. Thus, instead 'Invalid credentials.' we had 'User "foo" not found.'.

@Ioni14 Ioni14 changed the title [SecurityBundle] fix security.authentication.provider.ldap_bind argum… [SecurityBundle] fix ldap_bind service arguments Jan 22, 2020
nicolas-grekas
nicolas-grekas previously approved these changes Jan 22, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jan 22, 2020
@nicolas-grekas nicolas-grekas dismissed their stale review January 22, 2020 19:53

Tests are broken!

@nicolas-grekas
Copy link
Member

Good catch, thanks @Ioni14.

nicolas-grekas added a commit that referenced this pull request Jan 27, 2020
This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle] fix ldap_bind service arguments

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT

The 6th argument of `LdapBindAuthenticationProvider` was not correctly set in the service declaration `security_listeners.xml`. Thus, instead `'Invalid credentials.'` we had `'User "foo" not found.'`.

Commits
-------

7ec6a09 [SecurityBundle] fix security.authentication.provider.ldap_bind arguments
@nicolas-grekas nicolas-grekas merged commit 7ec6a09 into symfony:4.4 Jan 27, 2020
This was referenced Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants