[Security] Improved error message when no supported user provider is found #35472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Jan 25, 2020
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #35435 |
| License | MIT |
| Doc PR | - |
chalasr
reviewed
Jan 25, 2020
src/Symfony/Component/Security/Http/Firewall/ContextListener.php
Outdated
Show resolved
Hide resolved
d6b3e41 to
fdc4726
Compare
chalasr
reviewed
Jan 26, 2020
src/Symfony/Component/Security/Http/Firewall/ContextListener.php
Outdated
Show resolved
Hide resolved
|
Thanks for the quick review (and much nicer wording!), should be ready now. |
fdc4726 to
a3406da
Compare
chalasr
approved these changes
Jan 26, 2020
|
This applies to 3.4 isn't it? |
|
Oh sorry, yes should be 3.4 |
nicolas-grekas
approved these changes
Jan 27, 2020
a3406da to
6b2db6d
Compare
|
Thank you @wouterj. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2020
… provider is found (wouterj) This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead. Discussion ---------- [Security] Improved error message when no supported user provider is found | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #35435 | License | MIT | Doc PR | - Commits ------- 6b2db6d Improved error message when no supported user provider is found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.