[Cache] Don't allow mysqli to be used as it doesn't work #35473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21fb4f1 to
a786448
Compare
nicolas-grekas
approved these changes
Jan 27, 2020
|
Thank you @duncan3dc. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2020
… (duncan3dc) This PR was merged into the 4.3 branch. Discussion ---------- [Cache] Don't allow mysqli to be used as it doesn't work | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | As discussed in #35375 Mysqli doesn't support named parameters, so if you pass a doctrine connection using `mysqli` then you get errors for any queries using named parameters. This PR ensures a clear error is provided and suggests to use `pdo_mysql` instead Commits ------- a786448 Mysqli doesn't support the named parameters used by PdoAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #35375 Mysqli doesn't support named parameters, so if you pass a doctrine connection using
mysqlithen you get errors for any queries using named parameters.This PR ensures a clear error is provided and suggests to use
pdo_mysqlinstead