[Validator] fix access to uninitialized property when getting value #35532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 31, 2020
xabbuh
approved these changes
Jan 31, 2020
fabpot
approved these changes
Jan 31, 2020
|
Thank you @greedyivan. |
fabpot
added a commit
that referenced
this pull request
Jan 31, 2020
…ing value (greedyivan) This PR was squashed before being merged into the 3.4 branch (closes #35532). Discussion ---------- [Validator] fix access to uninitialized property when getting value | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35454 | License | MIT | Doc PR | In PHP 7.4, the type-hinted property is [uninitialized](https://wiki.php.net/rfc/typed_properties_v2#uninitialized_and_unset_properties) by default. So it needs to be checked before use. Commits ------- 1edecf7 [Validator] fix access to uninitialized property when getting value
This was referenced Jan 31, 2020
Merged
Merged
Merged
Merged
|
@nicolas-grekas Hi, would you mind please documenting this also here: Because there's not name of Constraint that would imply check for uninitialized property, so people often times just use Which is completely fine since this commit/MR merged but it's not documented anywhere - or at least I didn't find it anywhere in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 7.4, the type-hinted property is uninitialized by default. So it needs to be checked before use.